Revert 97dc86b and fix #607 #608
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephematician
force-pushed
the
fix_dqbuf_ring
branch
from
a1411c9 to
183bcdd
Compare
|
I'm assuming that this doesn't change (expected) behaviour for readers; i.e. that they'll read from the most-recently queued buffer as it comes available. From what I understand, this should be the case. |
|
Ah, I found the original issue: #116 - I'll test that this hasn't caused a reversion. |
|
Tested with a Logitech C270 webcam connected to user@home:~$ sudo modprobe v4l2loopback max_buffers=4 video_nr=2
user@home:~$ gst-launch-1.0 v4l2src device=/dev/video0 ! image/jpeg, width=1280, height=720, framerate=30/1 ! v4l2sink device=/dev/video2Did not fail. |
|
Should also fix #191. |
|
thx. i'll try to find time to look into this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore FIFO management of
dev->outbuf_list; fixes #607.A bug was introduced in 97dc86b where the tail of
dev->outbuf_listwas being used as the return value of DQBUF for an output application; this meant that the most-recently queued buffer was being used even if it hadn't been read or was in the process of being read by a capture application (potential for 'tearing'). Further more, by adding the buffer back to the tail - none of the other buffers were ever used.